[vlc-devel] Some commits have disappeared

[Steve Lhomme]

On 2020-11-17 12:31, Rémi Denis-Courmont wrote:
> Hi,
> 
> Considering that I asked to revert, there was notice. You can argue 
> semantics whether that's quite a notice or not. You can argue thay 
> revert and removal are different (though I think removal is better where 
> possible). And as I said, I will take responsibility for both of those 
> inconsistencies.

You shouldn't take responsibility for someone else's outrageous actions.

> But you're being contradictory. Steve has refused to revert. Can't 

I never refused it. I never even had the time to do it. I only noticed 
the commits where gone when Romain mentioned it on Monday.

> exactly blame a revert that was supposed to happen. This is just 

How can you come to the conclusion it was supposed to happen. You don't 
decide for everyone else, starting with me. At the very least it should 
have been discussed. And we did continue the discussion on the patches. 
I have no problem with that.

> diverting attention from the real issue of a certain developer's 
> attitude to code review.
> 
> 
> (And I don't think I ever ignored code review on core since it's been 
> made mandatory. I specifically went through code review for all the core 
> parts of the YT-DL work.)
> 
> Le 17 novembre 2020 13:18:37 GMT+02:00, Thomas Guillem <thomas at gllm.fr> 
> a écrit :
> 
> 
> 
>     On Tue, Nov 17, 2020, at 12:01, Rémi Denis-Courmont wrote:
>>     Those patches had no rights to merged and I correctly asked for
>>     them to be removed.
> 
>     It already happened in the past: problem of communication, leading
>     to patch that is pushed but should not have to. This is not a CoC
>     violation, it's a developing error / ML incomprehension. When it
>     happens, we generally ask for a revert and the developer generally
>     fix his commits or revert them. There is no need to push force when
>     that situation occurs.
> 
>>
>>     Thanks to whomever did it.
>>
>>     I find your false accusations of outrageous and in violation of
>>     the CoC. The one who violated the rules is Steve.
> 
>     Which accusations are outrageous? I don't think I accused anyone.
> 
>>
>>     And then he insulted me on top.
>>
>>     Le 17 novembre 2020 12:00:49 GMT+02:00, Thomas Guillem
>>     <thomas at gllm.fr> a écrit :
>>
>>         Ping.
>>
>>         Somebody push --forced without notifying us on the ML. This is
>>         a CoC violation or a security issue.
>>
>>         https://wiki.videolan.org/Code_of_Conduct/
>>         <https://wiki.videolan.org/Code_of_Conduct/>
>>         "Do NOT delete another developer's commit without approval by
>>         using push --force."
>>
>>         On Mon, Nov 16, 2020, at 11:10, Romain Vimont wrote:
>>
>>             Hi,
>>
>>             When I git-pulled this morning, it refused:
>>
>>             fatal: Not possible to fast-forward, aborting.
>>
>>             Some commits I retrieved previously have been removed from
>>             the master
>>             branch:
>>
>>             $ git log --oneline origin/master..master
>>             e326d846bf (master) decoder: make sure decoder updates use
>>             enough
>>             output pictures
>>             270d501bf3 video_output: change the deinterlacing filter
>>             before
>>             displaying the picture
>>             9591771a6b video_output: allow changing the interlacing
>>             mode while
>>             locked
>>             3d0e4ebb14 video_output: get rid of the internal
>>             "deinterlace-needed" variable
>>             05acaa1e45 video_output: let the deinterlacing code access
>>             vout_thread_interlacing_t
>>             ebbbdf7d83 video_output: use a separate structure for the
>>             deinterlacing state
>>             14588c7d06 video_output: change the filters before
>>             checking for
>>             late frames
>>             d4c036a5f3 video_output: allow flushing filters without
>>             flusing the
>>             displayed.current
>>             3d13aad3b4 video_output: keep the displayed.current in
>>             frame by
>>             frame if next is not ready
>>             b7503cbfec video_output: move up a test on NULL
>>             displayed.current
>>             42011517f3 video_output: don't use displayed.next in frame
>>             by frame
>>             mode
>>             9eb231ed0d libvlc: set a name on the medialist seek thread
>>             d6f0a4215a modules: set names to threads created in modules
>>             2415cec16a core: set names to threads created in the core
>>             5bc16beec1 thread: add a function to give names to threads
>>
>>             Was it on purpose?
>>
>>             Regards
>>             ------------------------------------------------------------------------
>>             vlc-devel mailing list
>>             To unsubscribe or modify your subscription options:
>>             https://mailman.videolan.org/listinfo/vlc-devel
>>             <https://mailman.videolan.org/listinfo/vlc-devel>
>>
>>         ------------------------------------------------------------------------
>>         vlc-devel mailing list
>>         To unsubscribe or modify your subscription options:
>>         https://mailman.videolan.org/listinfo/vlc-devel
>>         <https://mailman.videolan.org/listinfo/vlc-devel>
>>
>>
>>     -- 
>>     Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>     excuser ma brièveté.
>>     _______________________________________________
>>     vlc-devel mailing list
>>     To unsubscribe or modify your subscription options:
>>     https://mailman.videolan.org/listinfo/vlc-devel
>>     <https://mailman.videolan.org/listinfo/vlc-devel>
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>