Compiled 0.2.92 for Mac OS X

Sat Jan 19 19:33:08 CET 2002

le 19/01/02 18:13, Florian G. Pflug à fgp at phlo.org a écrit :

> On Sat, Jan 19, 2002 at 05:37:27PM +0100, Stéphane Sudre wrote:
>> - the 19/01/2002 snapshots does not compile at all on Mac OS X.
>> - I don't know what reason was behind the switch from Carbon to Cocoa but
>> the person who coded the current Cocoa Front-End does not know how to code
>> in Objective-C & Cocoa (it's not to be bad or pretentious, it's just the
>> facts). 
> So, guess this makes me the one "knowing nothing about coding in Objective-C
> & Cocoa".

I couldn't guess, your user name on your machine is meuuh :-)

> Unstable (the CVS version) is currently changing quite fast, and I don't
> have to time to keep up with this. Once unstable begins to stabilize again,
> the MacOSX-Port will be synced with the rest of vlc. Most of the other ports
> (BeOS, Win32, even QT I think) have the same problems regarding unstable,
> and I think most of them don't compile at the moment.

That's the feeling I had when I looked at the module part. It seems one
platform code (the main one I suppose) is up-to-date without taking into
considerations the other platforms.

> That's the reason that there is a v0_2_92_branch in the CVS. It was branched
> before the massive changes, and everything should compile there.
> 
> I don't claim to be an expert in either Cocoa or Objective-C. If you feel
> there the design of my code is bad, or that I got some things wrong, please
> don't state "You don't know anything", but rather state "See, you should do
> things like THIS, and not like THAT, because THIS has THOSE advantages over
> THAT".
> 
> You could even state "You don't know anything, stupid" at the beginning of
> your mail as long as you do explain what _exactly_ I'm doing wrong later on.

I didn't say you were stupid (that's the reason why I precised these were
just facts). If you want detailed information why I have this opinion, here
are some points:
- the extension for Objective-C files is .m. In the code, the Objective-C
files have the .c extension. This leads to Project Builder not being able
for instance to index the source code.
- the use of a NSQuickDrawView is really really weird. I don't see what is
so important in QuickDraw that you can't get with a standard NSView and the
use of a NSBitmapImageRep or the use of the CoreGraphics API using the
CoreGraphic Context obtained from the NSView Graphic context.
- the Project is made to compile a .bundle (I don't see how you can obtain a
.app from the current project settings). I'm using the September Dev Tools
and there is no major difference in this version from the last version : Dec
Tool.
- the use of .png files for graphics in Cooca is weird. Every project I've
seen is using .tiff files.
- I don't see the interest in playing with Drawers when only 2-4 outlets are
linked in the UI. The Stop button is not even linked IIRC.
- part of the code is strange (the part regarding the use of the NSApp
runloop for instance), it may be correct but it's definitely not coded in an
Objective-C way (style?).

>> - From the comments in the source code and parts of the source code, it
>> seems the Mac OS X specific parts are not aligned on the most recent part of
>> the code. MODULE_NULL something is defined nowhere for instance (the qnx
>> part seems to be affected to)
>> - Parts of the code seems to be coded strangely in the module section. Doing
>> a bit OR on integer from 0 to 8 is not considered clever. It may be lacking
>> a power of 2 somewhere.
> See statement above.

This does not prevent it to be space.

>> - the 0.2.92 binary is not working at all (in fact I've only been able to
>> get a snaily, clunky audio output from one file on the Matrix DVD on a Power
>> Mac G4 450 MHz). At least the 0.2.90 was able to read the beginning of some
>> MPEG2 files before crashing. Currently, opening a file with the Cocoa GUI is
>> going to do one of the following thing:
>> * crash the application
>> * do nothing
>> * display an empty window (which will never get filled if you have a look at
>> the code).
> It works for me, and I haven't been able to reproduce those bugs. I'm aware
> of the fact that a lot of people have problems with the OSX port, but I
> honestly don't know how to debug this, if it runs fine on my machine.

I did the test with the following DVDs:

Matrix Zone 1
Deep Blue Sea Zone 1

and the following MPEG-1 or 2 file:

Alien Song

Which configuration are you using? Honestly, I really never have been able
to play a DVD file with the VLC Client (Carbon or Cocoa GUI).

>> As just an occasional user, I just have 2 questions for the Mac OS X part:
>> 
>> has there ever been a working Mac OS X binary released and what was the
>> version of the binary?
> See statement above. I have made a new 0.2.92 binary a few days agon, but
> didn't upload it yet. I will do that.

This may explain everything because I swear that the current 0.2.92
available on the web site is not working at all.

>> It's a huge and complex project but I really don't understand why the CVS is
>> including know-buggy and impossible to compile code. That sounds completely
>> illogical.
> The CVS is branched. Those things work for the v0_2_92_branch. See
> statements above.
> 
> 
> Your statement that "I don't know nothing about Objective-C & Cocoa" implies
> that you _do_ know something about those. I invite you to work on the
> MacOSX-Port, and fix the bugs that are anoying you.

That was my original will as soon as I saw the GUI Front-End was switched to
Cocoa. The problem is that the current source code is not compiling at all
(a simple example is the use of a TestMethod which is defined nowhere). I'm
not able to help on the engine since it's too complex for me but on the GUI
I may be of some help.

This morning, I was trying to see if some little modifications in the
specific Mac OS X parts would be possible tomake it compile but things like
the MODULE_NULL and TestMethod makes it impossible to compile.

Regards,

-- 
Stephane

-- 
This is the vlc mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://www.videolan.org/lists.html