[x264-devel] commit: Resolve floating point exception with frame_init_lowres mmx ( Jason Garrett-Glaser )
git version control
git at videolan.org
Sun Jul 6 19:15:30 CEST 2008
x264 | branch: master | Jason Garrett-Glaser <darkshikari at gmail.com> | Sun Jul 6 11:15:19 2008 -0600| [a9af9425820cfba99ae4b378c33c4fee4e99b2ce]
Resolve floating point exception with frame_init_lowres mmx
In some cases, the mmx version of frame_init_lowres could leave the FPU uninitialized for use in ratecontrol, resulting in floating point exceptions.
Since frame_init_lowres is such a time-consuming function, an emms was just put at the end, since it costs almost nothing compared to the total time of frame_init_lowres.
> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=a9af9425820cfba99ae4b378c33c4fee4e99b2ce
---
common/x86/mc-a2.asm | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/common/x86/mc-a2.asm b/common/x86/mc-a2.asm
index eb35204..514b3d8 100644
--- a/common/x86/mc-a2.asm
+++ b/common/x86/mc-a2.asm
@@ -643,6 +643,7 @@ cglobal x264_frame_init_lowres_core_%1, 6,7
dec dword r8m
jg .vloop
ADD rsp, 2*push_size
+ emms
RET
%endmacro ; FRAME_INIT_LOWRES
More information about the x264-devel
mailing list