[x264-devel] Updated threaded slicetype patch

[Steven Walters]

doesn't compile when HAVE_PTHREAD is defined in mingw nor cygwin.
threadless building works fine though.

mingw (gcc 3.4.5) (my gcc 4.3.4 x64 build doesn't compile it either):
gcc -O4 -ffast-math  -Wall -I. -DHAVE_MMX -DARCH_X86 -DSYS_MINGW
-DPTW32_STATIC_LIB -DHAVE_PTHREAD -s -fomit-frame-pointer   -c -o
encoder/lookahead.o encoder/lookahead.c

cygwin (gcc 3.4.4):
gcc -O4 -ffast-math  -Wall -I. -mno-cygwin -DHAVE_MMX -DARCH_X86
-DSYS_MINGW -DHAVE_PTHREAD -s -fomit-frame-pointer   -c -o
encoder/lookahead.o encoder/lookahead.c

errors on this file:
encoder/lookahead.c: In function `x264_lookahead_init':
encoder/lookahead.c:126: error: incompatible types in assignment
encoder/lookahead.c: In function `x264_lookahead_destroy':
encoder/lookahead.c:363: error: incompatible type for argument 1 of
`pthread_join'
encoder/lookahead.c:364: error: incompatible types in assignment
make: *** [encoder/lookahead.o] Error 1

other possible issues:
encoder/encoder.c: In function `x264_encoder_close':
encoder/encoder.c:1923: warning: passing arg 2 of
`x264_lookahead_destroy' makes integer from pointer without a cast

compiles cleanly on linux though ;)

2009/2/13 Mike Kazmier <DaKaZ at zenbe.com>:
> All - well, this has certainly not been an easy project, but ultimately I think it is very worthwhile.  Please find attached the latest release candidate for the threaded slicetype patch.  Results from my testing have been quite impressive, hopefully no one can break this one (especially not on their first test case!) - but, if you do, please let me know right away so we can get this patch into the mainline code.
>
> Thanks!
>
> --DaKaZ
>
>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>
>