[x264-devel] Yet another updated threaded slicetype patch (v14)

[Chase Geigle]

I can get the v14 patch and the windows fix to segfault on the second 
pass of two pass encodes, however, my crf encodes were unaffected. Here 
is a backtrace (if useful at all):

(gdb) run
Starting program: C:\msys\1.0\home\Chase\x264/x264.exe --pass 2 
--bitrate 5000 --stats lol.stats -o touhou.mkv LosslessTouhou.y4m 
--lookahead 10 --ref 16 --mixed-refs --bframes 10 --b-pyramid --weightb 
--direct auto --subme 9 --deblock -1,-1 --trellis 2 --partitions all  
--8x8dct --me umh --merange 24 --psy-rd 1.0:0 --threads 6 --thread-input 
--progress --no-dct-decimate --no-psnr --no-ssim
[New thread 140876.0x225ac]
yuv4mpeg: 640x480 at 5000000/83333fps, 0:0
x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 Cache64
x264 [warning]: direct=auto not used on the first pass
x264 [info]: profile High, level 3.2
[New thread 140876.0x22508]0 fps, 0.00 kb/s, eta 0:00:00
[New thread 140876.0x2271c]
[New thread 140876.0x22678]
[New thread 140876.0x221a0]
[New thread 140876.0x21b78]
[New thread 140876.0x22674]
[New thread 140876.0x226fc]
[New thread 140876.0x22544]
[New thread 140876.0x222d0]
[New thread 140876.0x22600]
[New thread 140876.0x226e0]
[New thread 140876.0x22700]

Program received signal SIGSEGV, Segmentation fault.
[Switching to thread 140876.0x22508]
x264_ratecontrol_slice_type (h=0x274cdb0, frame_num=0)
     at encoder/ratecontrol.c:1012
1012            if( frame_num >= rc->num_entries )
(gdb) Error: dll starting at 0x76ce0000 not found.
Error: dll starting at 0x75a50000 not found.
Error: dll starting at 0x76ce0000 not found.
Error: dll starting at 0x76e10000 not found.
bt
#0  x264_ratecontrol_slice_type (h=0x274cdb0, frame_num=0)
     at encoder/ratecontrol.c:1012
#1  0x00433ae1 in x264_slicetype_decide (h=0x274cdb0)
     at encoder/slicetype.c:609
#2  0x00426ba4 in x264_stack_align ()
#3  0x00413043 in _x264_lookahead_slicetype_decide (h=0x274cdb0)
     at encoder/lookahead.c:321
#4  0x0041331e in x264_lookahead_thread (h=0x274cdb0)
     at encoder/lookahead.c:413
#5  0x00481465 in ptw32_threadStart at 4 ()
#6  0x75672cce in wcstombs_s () from C:\Windows\syswow64\msvcrt.dll
#7  0x75672deb in msvcrt!_beginthreadex () from 
C:\Windows\syswow64\msvcrt.dll
#8  0x75ade3f3 in UnhandledExceptionFilter ()
    from C:\Windows\syswow64\kernel32.dll
#9  0x0002f930 in ?? ()
#10 0x02aeffd4 in ?? ()
#11 0x770fcfed in ntdll!RtlWalkFrameChain ()
    from C:\Windows\system32\ntdll.dll
#12 0x0002f930 in ?? ()
#13 0x7042a144 in ?? ()
#14 0x00000000 in ?? ()


Looking forward to seeing this patch in its final version, and I hope 
this will be of some use.