[x264-devel] [PATCH] Fix linker test for -Bsymbolic

Sean McGovern gseanmcg at gmail.com
Wed Apr 20 01:39:14 CEST 2011


On Tue, Apr 19, 2011 at 1:23 PM, Sean McGovern <gseanmcg at gmail.com> wrote:

> That's what I figured -- OK so I should just add -mimpure-text to the
> Solaris LDFLAGS and be done with it? If so, I'll send a patch this
> evening.
>
> -- Sean
>
> On 4/19/11, BugMaster <BugMaster at narod.ru> wrote:
> > On Mon, 18 Apr 2011 18:51:52 -0400, Sean McGovern wrote:
> >
> >> Is copy-on-write something to be concerned about? Is the assembler
> >> code in common/x86/ supposed to be at least PIC-friendly on x86_32?
> >
> > Look at this from x86inc.asm:
> > %ifdef WIN64
> >     %define PIC
> > %elifndef ARCH_X86_64
> > ; x86_32 doesn't require PIC.
> > ; Some distros prefer shared objects to be PIC, but nothing breaks if
> > ; the code contains a few textrels, so we'll skip that complexity.
> >     %undef PIC
> > %endif
> >
> > So if by PIC-friendly you mean "don't have textrels" than answer is
> > "no".
> >
> > _______________________________________________
> > x264-devel mailing list
> > x264-devel at videolan.org
> > http://mailman.videolan.org/listinfo/x264-devel
> >
>
> --
> Sent from my mobile device
>

Please ignore the previous patch -- I am having trouble with the x264 binary
now. Will re-think this and send a patch soon.

-- Sean
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20110419/332ef5da/attachment.html>


More information about the x264-devel mailing list