[x265] [PATCH] lowres: right and bottom margins are being extended twice?

[Steve Borho]

On Mon, Oct 21, 2013 at 5:45 AM, <deepthi at multicorewareinc.com> wrote:

> # HG changeset patch
> # User Deepthi Nandakumar <deepthi at multicorewareinc.com>
> # Date 1382352322 -19800
> # Node ID f987c24c7bf2d3e6df0f96b2c75f3e71ab15a85e
> # Parent  b2aa2aad2c6654797befe6098b7d14609b060299
> lowres: right and bottom margins are being extended twice?
>
> diff -r b2aa2aad2c66 -r f987c24c7bf2 source/common/lowres.cpp
> --- a/source/common/lowres.cpp  Mon Oct 21 12:55:18 2013 +0530
> +++ b/source/common/lowres.cpp  Mon Oct 21 16:15:22 2013 +0530
> @@ -158,25 +158,7 @@
>      {
>          ::memcpy(src + y * srcStride, src, sizeof(Pel) * (extWidth));
>      }
> -
> -    /* extending right margin*/
> -    if (2 * width > orig->getWidth())
> -    {
> -        for (y = 0; y < srcHeight; y++)
> -        {
> -            ::memset(src + srcWidth, src[srcWidth - 1], sizeof(Pel) *
> (X265_LOWRES_CU_SIZE - 1));
> -            src += srcStride;
> -        }
> -    }
> -
> -    /* extending bottom margin */
> -    src = orig->getLumaAddr() + (srcHeight - 1) * srcStride;
> -
> -    for (y = 1; y <= 2 * lines - srcHeight; y++)
> -    {
> -        ::memcpy(src + y * srcStride, src, sizeof(Pel) * (extWidth));
> -    }
> -
> +
>

good catch; not sure what happened here


>      /* downscale and generate 4 HPEL planes for lookahead */
>      primitives.frame_init_lowres_core(orig->getLumaAddr(),
>                                        lowresPlane[0], lowresPlane[1],
> lowresPlane[2], lowresPlane[3],
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>



-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20131021/3aed7a39/attachment.html>