[x265] [PATCH] lookahead: fix crash for I frame cost estimation

[Steve Borho]

On Thu, Sep 19, 2013 at 2:25 AM, Deepthi Devaki Akkoorath <
deepthidevaki at multicorewareinc.com> wrote:

>
>
>
> On Thu, Sep 19, 2013 at 12:19 PM, Deepthi Nandakumar <
> deepthi at multicorewareinc.com> wrote:
>
>>
>>
>> On Thu, Sep 19, 2013 at 11:55 AM, <deepthidevaki at multicorewareinc.com>wrote:
>>
>>> # HG changeset patch
>>> # User Deepthi Devaki <deepthidevaki at multicorewareinc.com>
>>> # Date 1379571920 -19800
>>> # Node ID 93d222ec321e5eed93dc8652dc9e5248d836c436
>>> # Parent  26d6f155f8df69147f40f4945d99c29a52988c56
>>> lookahead: fix crash for I frame cost estimation
>>>
>>> diff -r 26d6f155f8df -r 93d222ec321e source/encoder/slicetype.cpp
>>> --- a/source/encoder/slicetype.cpp      Wed Sep 18 16:13:33 2013 -0500
>>> +++ b/source/encoder/slicetype.cpp      Thu Sep 19 11:55:20 2013 +0530
>>> @@ -365,7 +365,8 @@
>>>          if (!bDoSearch[i])
>>>          {
>>>              /* Use previously calculated cost */
>>> -            COPY2_IF_LT(bcost, *fenc_costs[i], listused, i + 1);
>>> +            if(p0 != p1)
>>>
>>
>> Can we move this check (for intra-slices) to outside the for-loop?
>>
>
> Yes. Infact, it doesnt have to enter the loop if Intra slice.
>


x264 actually uses a goto here to skip inter searches entirely and jump to
the intra checks


>
>
>>
>>
>>>  +                COPY2_IF_LT(bcost, *fenc_costs[i], listused, i + 1);
>>>              continue;
>>>          }
>>>          int numc = 0;
>>> _______________________________________________
>>> x265-devel mailing list
>>> x265-devel at videolan.org
>>> https://mailman.videolan.org/listinfo/x265-devel
>>>
>>
>>
>> _______________________________________________
>> x265-devel mailing list
>> x265-devel at videolan.org
>> https://mailman.videolan.org/listinfo/x265-devel
>>
>>
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>


-- 
Steve Borho
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130919/50acad49/attachment.html>