[x265] [PATCH] asm code for ipfilterH_pp, 4 tap filter

Praveen Tiwari praveen at multicorewareinc.com
Sat Sep 28 08:42:34 CEST 2013


suppose, during execution width comes less than 8 like 5, then we would
like to run our code section which handles the reaming width (_end_col:)
not the whole code (handle multiple of 8 and renaming width part, it will
computed twice in this case and  corrupting some (8 - widthleft) dst[] old
values which is being used with 'pblenvb' instruction.This is why we have
put a check. if width is always >= 8 you are right, we don't need to put
the check.

Regards,
praveen


On Fri, Sep 27, 2013 at 9:05 PM, Jason Garrett-Glaser <jason at x264.com>wrote:

> > +_loop_row:
> > +    xor         col,        col
> > +    cmp                width,      0
> > +    je         _end_col
>
> I don't understand this. Why do we have to do this check?
>
> Jason
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20130928/2a46fb10/attachment.html>


More information about the x265-devel mailing list