[x265] [PATCH] asm code for ipfilterH_pp, 4 tap filter

Jason Garrett-Glaser jason at x264.com
Sat Sep 28 13:00:01 CEST 2013


On Fri, Sep 27, 2013 at 11:42 PM, Praveen Tiwari
<praveen at multicorewareinc.com> wrote:
> suppose, during execution width comes less than 8 like 5, then we would like
> to run our code section which handles the reaming width (_end_col:) not the
> whole code (handle multiple of 8 and renaming width part, it will computed
> twice in this case and  corrupting some (8 - widthleft) dst[] old values
> which is being used with 'pblenvb' instruction.This is why we have put a
> check. if width is always >= 8 you are right, we don't need to put the
> check.

Wait, so you're using pblendvb to avoid corrupting pixels to the right
of the block being stored?

That really doesn't seem necessary; x264's MC functions just wrote
past the end and this was never a problem, because blocks to the right
hadn't been encoded yet anyways.

Does HEVC really have width-5 blocks?  I thought the widths were 4, 8,
and so forth; did they add odd-size blocks?  What is the exact,
complete list of widths we need to support?

Jason


More information about the x265-devel mailing list