[x265] [PATCH] SEI: Insert buffering period and picture timing SEI messages

[Steve Borho]

On Sun, Jun 1, 2014 at 11:40 AM,  <kavitha at multicorewareinc.com> wrote:
> # HG changeset patch
> # User Kavitha Sampath <kavitha at multicorewareinc.com>
> # Date 1401640530 -19800
> #      Sun Jun 01 22:05:30 2014 +0530
> # Node ID 322bcc4d26dd358d946b9e8da369f52690344af4
> # Parent  592ef184549ef631c0fe725cb9fe3cbab8de1db4
> SEI: Insert buffering period and picture timing SEI messages
>
> The buffering period SEI message is inserted for every key frame and the
> picture timing SEI is inserted for every frame. The commit also computes the
> HRD parameters carried in these SEI messages. HRD parameters are signalled by
> enabling --hrd.

clang is generating a warning from this patch that indicates a likely bug:

/Users/steve/repos/x265/source/encoder/ratecontrol.cpp:746:17:
warning: comparison of unsigned expression < 0 is always false
[-Wtautological-compare]

    if(cpbState < 0 || cpbState > cpbSize)

       ~~~~~~~~ ^ ~

/Users/steve/repos/x265/source/encoder/ratecontrol.cpp:749:29:
warning: comparison of unsigned expression < 0 is always false
[-Wtautological-compare]

                   cpbState < 0 ? "underflow" : "overflow",
(float)cpbState/denom, (float)cpbSize/denom);

                   ~~~~~~~~ ^ ~

-- 
Steve Borho