[x265] [PATCH 2 of 6] rc: define default setting and validations for 2 pass states

[Steve Borho]

On Sun, Jun 15, 2014 at 11:07 PM, Steve Borho <steve at borho.org> wrote:
> On Sun, Jun 15, 2014 at 1:50 PM,  <aarthi at multicorewareinc.com> wrote:
>> # HG changeset patch
>> # User Aarthi Thirumalai<aarthi at multicorewareinc.com>
>> # Date 1402857077 -19800
>> #      Mon Jun 16 00:01:17 2014 +0530
>> # Node ID d1f636a6dc0a11657bb25be650de60345c2952c8
>> # Parent  438a03ff94830fbc17457b6f324397e643c17cba
>> rc: define default setting and validations for 2 pass states
>>
>> diff -r 438a03ff9483 -r d1f636a6dc0a source/common/param.cpp
>> --- a/source/common/param.cpp   Sun Jun 15 23:59:14 2014 +0530
>> +++ b/source/common/param.cpp   Mon Jun 16 00:01:17 2014 +0530
>> @@ -180,7 +180,12 @@
>>      param->rc.cuTree = 1;
>>      param->rc.rfConstantMax = 0;
>>      param->rc.rfConstantMin = 0;
>> -
>> +    param->rc.pszStatIn = "x265_2pass.log";
>
> default filenames are a no-no

I was wrong here, it's ok to hard-code default filenames in the CLI
for when --pass N is specified without --stats <fname>

We just don't want to hard-code the names here in param.cpp.  The
default name should be in x265.cpp.  Care will need to be taken to
make sure "--pass 1 --stats FOO" works the same as "--stats FOO --pass
1"

-- 
Steve Borho