[x265] [PATCH] restore WINXP_SUPPORT build option, workaround for CONDITION_VARIABLE on XP

[JMK]

Just confirming what LigH said, the latest commit b0rks the 64-bit target under MinGW.
Reverting to the "original recipe" avoids the problem:

«
if (WIN32)
   option(WINXP_SUPPORT "Make binaries compatible with Windows XP" OFF)
    if(WINXP_SUPPORT)
       add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_WINXP)
    elseif(MINGW)
       add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_VISTA)
    endif()
endif()
»

Sorry, I have no use for the Visual Leak Detector :-)

======= ORIGINAL MESSAGE BELOW ===========

--- contact at ligh.de wrote:

From: Mario Rohkrämer <contact at ligh.de>
To: "Development for x265" <x265-devel at videolan.org>
Subject: Re: [x265] [PATCH] restore WINXP_SUPPORT build option, workaround for CONDITION_VARIABLE on XP
Date: Sun, 30 Mar 2014 05:47:10 +0200

Am 30.03.2014, 03:18 Uhr, schrieb Steve Borho <steve at borho.org>:

> Thanks for testing.  Since the gravity seems to lean towards XP, I'll
> leave that as the default for MinGW builds

But this seems to break compiling when WINXP_SUPPORT is not enabled (which  
would be not useful for x86_64 Win64 cross compiles, but may not  
necessarily be enabled either for x86 Win32 builds).

+----
H:/MSYS/home/LigH/x265/source/common/threading.h: In constructor  
'x265::ThreadSafeInteger::ThreadSafeInteger()':
H:/MSYS/home/LigH/x265/source/common/threading.h:201:42: error:  
'InitializeConditionVariable' was not declared in this scope
          InitializeConditionVariable(&m_cv);
                                           ^
H:/MSYS/home/LigH/x265/source/common/threading.h: In member function 'int  
x265::ThreadSafeInteger::waitForChange(int)':
H:/MSYS/home/LigH/x265/source/common/threading.h:214:60: error:  
'SleepConditionVariableCS' was not declared in this scope
              SleepConditionVariableCS(&m_cv, &m_cs, INFINITE);
                                                             ^
H:/MSYS/home/LigH/x265/source/common/threading.h: In member function 'void  
x265::ThreadSafeInteger::set(int)':
H:/MSYS/home/LigH/x265/source/common/threading.h:231:39: error:  
'WakeAllConditionVariable' was not declared in this scope
          WakeAllConditionVariable(&m_cv);
                                        ^
H:/MSYS/home/LigH/x265/source/common/threading.h: In member function 'void  
x265::ThreadSafeInteger::incr()':
H:/MSYS/home/LigH/x265/source/common/threading.h:239:39: error:  
'WakeAllConditionVariable' was not declared in this scope
          WakeAllConditionVariable(&m_cv);
                                        ^
+----

-- 

Fun and success!
Mario *LigH* Rohkrämer
mailto:contact at ligh.de
_______________________________________________
x265-devel mailing list
x265-devel at videolan.org
https://mailman.videolan.org/listinfo/x265-devel




_____________________________________________________________
ps. Do you like my email address? Get yourself a coldmail.nu address too
http://www.coldmail.nu (it's free!)