[x265] [PATCH] restore WINXP_SUPPORT build option, workaround for CONDITION_VARIABLE on XP

JMK three4teen16 at coldmail.nu
Sun Mar 30 15:57:24 CEST 2014


> --- contact at ligh.de wrote:

> From: Mario Rohkrämer <contact at ligh.de>
> To: "Development for x265" <x265-devel at videolan.org>
> Subject: Re: [x265] [PATCH] restore WINXP_SUPPORT build option, workaround for CONDITION_VARIABLE on XP
> Date: Sun, 30 Mar 2014 05:47:10 +0200

>> Am 30.03.2014, 03:18 Uhr, schrieb Steve Borho <steve at borho.org>:

>> Thanks for testing.  Since the gravity seems to lean towards XP, I'll
>> leave that as the default for MinGW builds

> But this seems to break compiling when WINXP_SUPPORT is not enabled (which  
> would be not useful for x86_64 Win64 cross compiles, but may not  
> necessarily be enabled either for x86 Win32 builds).

FWIW, the following modification in "source\CMakeLists.txt" seems to work for me:

«
if(X64)
####
    option(HIGH_BIT_DEPTH "Store pixels as 16bit values" OFF)
####
    if(MINGW)
       add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_VISTA)
    endif(MINGW)
endif(X64)
»

&&&

«
if (WIN32)
   option(WINXP_SUPPORT "Make binaries compatible with Windows XP" OFF)
    if(WINXP_SUPPORT)
       add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_WINXP)
     endif()
endif()
»

Hope this helps.

_____________________________________________________________
ps. Do you like my email address? Get yourself a coldmail.nu address too
http://www.coldmail.nu (it's free!)


More information about the x265-devel mailing list