[x265] [PATCH] threadpool: use all available threads on each NUMA node with --pools=NULL option too

[Mahesh Pittala]

sure, will resend the patch.

On Thu, Dec 17, 2015 at 3:43 PM, Deepthi Nandakumar <
deepthi at multicorewareinc.com> wrote:

> Hmm, ok. Pls do a toupper before strcmp, so that you can account for
> lowercase inputs also.
> # HG changeset patch
> # User Mahesh Pittala <mahesh at multicorewareinc.com>
> # Date 1450172601 -19800
> #      Tue Dec 15 15:13:21 2015 +0530
> # Node ID d64d110a4f92e1e78ee48da8007a2d7cef6fe1b7
> # Parent  e951ab673b1c3d41ef86bc623f20ecc768d3f5c5
> threadpool: use all available threads on each NUMA node with --pools=NULL
> option too
>
>
> from x265.readthedocs, --pools = NULL, "", "*" are doing same
> functionality.
> --pools="" & --pools="*" are using all threads but when we pass
> --pools=NULL, disabled
> all threads pools but supposed to enable.
>
> diff -r e951ab673b1c -r d64d110a4f92 source/common/threadpool.cpp
> --- a/source/common/threadpool.cpp      Fri Dec 11 07:33:41 2015 +0530
> +++ b/source/common/threadpool.cpp      Tue Dec 15 15:13:21 2015 +0530
> @@ -277,7 +277,7 @@
>              }
>              else if (*nodeStr == '-')
>                  threadsPerPool[i] = 0;
> -            else if (*nodeStr == '*')
> +            else if (*nodeStr == '*' || !strcmp(nodeStr, "NULL"))
>              {
>                  for (int j = i; j < numNumaNodes; j++)
>                  {
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20151217/e454a4ca/attachment.html>