[x265] [PATCH] CMake: blacklist mingw implicit link libraries

[Ashok Kumar Mishra]

On Sun, Jan 28, 2018 at 4:00 PM, Ricardo Constantino <wiiaboo at gmail.com>
wrote:

>
>
> On 28 January 2018 at 06:45, Mario Rohkrämer <contact at ligh.de> wrote:
>
>> Am 23.01.2018, 13:02 Uhr, schrieb Ricardo Constantino <wiiaboo at gmail.com
>> >:
>>
>> On 16 January 2018 at 17:41, Ricardo Constantino <wiiaboo at gmail.com>
>>> wrote:
>>>
>>> # HG changeset patch
>>>> # User Ricardo Constantino <wiiaboo at gmail.com>
>>>> # Date 1516124393 0
>>>> #      Tue Jan 16 17:39:53 2018 +0000
>>>> # Node ID 5dbc1653fba42507f44fac6034aa3598fb2816cd
>>>> # Parent  3712d13c09bf3b9db105c7f97188bcc11b8f83cd
>>>> CMake: blacklist mingw implicit link libraries
>>>>
>>>> These also aren't meant to be in pkg-config's Libs.Private.
>>>>
>>>> diff -r 3712d13c09bf -r 5dbc1653fba4 source/CMakeLists.txt
>>>> --- a/source/CMakeLists.txt     Sat Jan 13 02:47:30 2018 +0100
>>>> +++ b/source/CMakeLists.txt     Tue Jan 16 17:39:53 2018 +0000
>>>> @@ -647,7 +647,9 @@
>>>>      endforeach()
>>>>      if(PLIBLIST)
>>>>          # blacklist of libraries that should not be in Libs.private
>>>> -        list(REMOVE_ITEM PLIBLIST "-lc" "-lpthread")
>>>> +        list(REMOVE_ITEM PLIBLIST "-lc" "-lpthread" "-lmingwex"
>>>> "-lmingwthrd"
>>>> +            "-lmingw32" "-lmoldname" "-lmsvcrt" "-ladvapi32"
>>>> "-lshell32"
>>>> +            "-luser32" "-lkernel32")
>>>>          string(REPLACE ";" " " PRIVATE_LIBS "${PLIBLIST}")
>>>>      else()
>>>>          set(PRIVATE_LIBS "")
>>>>
>>>>
>>> ping
>>>
>>
>> Hoping for a soon review and commit too...
>
>
> Maybe it would add to the urgency that not fixing this very horribly
> breaks MinGW static linking with any upstream using x265.
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>

Thank you for sending this patch, will commit it asap.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20180129/d973089c/attachment.html>