[x265] [arm64] Status and combined patch

Thu Sep 16 01:26:54 UTC 2021

I am re-sending ipfilters patch with gzipped attachment.

(The mailing list rejected the previous email with the patch larger than 200K.)

Sebastian

________________________________
From: Pop, Sebastian
Sent: Wednesday, September 15, 2021 8:21 PM
To: Gopi Satykrishna Akisetty; Development for x265
Subject: Re: [x265] [arm64] Status and combined patch

Hi,

Please find attached a patch that ports all ip filters to arm64.

The patch is to be applied on top of p2s patch.

For the moment only 8bit is accelerated.  I am still working on 10bit and 12bit.

With this patch I have seen better results on Graviton2 compared to the NEON intrinsics compiled with gcc-11 and clang-12.

Thanks,

Sebastian

________________________________
From: x265-devel <x265-devel-bounces at videolan.org> on behalf of Pop, Sebastian <spop at amazon.com>
Sent: Wednesday, September 15, 2021 7:15 PM
To: Gopi Satykrishna Akisetty
Cc: Development for x265
Subject: Re: [x265] [arm64] Status and combined patch

Hi,

Here is the updated patch for p2s on top of

https://bitbucket.org/multicoreware/x265_git/commits/4bf31dc15fb6d1f93d12ecf21fad5e695f0db5c0

Sebastian

________________________________
From: Pop, Sebastian
Sent: Thursday, September 9, 2021 3:45 AM
To: Gopi Satykrishna Akisetty
Cc: Liwei Wang; Siva Viswanathan; Janani T E; Development for x265
Subject: Re: [EXTERNAL] [x265] [arm64] Status and combined patch

Hi Gopi,

Please see attached the patch for p2s.

The patch passes TestBench for 8bit, 10bit, and 12bit configurations.

Next, I will submit all the ipfilter functions.

Thanks,

Sebastian

________________________________
From: Pop, Sebastian
Sent: Wednesday, September 8, 2021 12:40 PM
To: Gopi Satykrishna Akisetty
Cc: Liwei Wang; Siva Viswanathan; Janani T E; Development for x265
Subject: Re: [EXTERNAL] [x265] [arm64] Status and combined patch

Thanks Gopi for the instructions.

I was able to see TestBench failing for 10bit and 12bit configurations.

Sebastian

________________________________
From: Gopi Satykrishna Akisetty <gopi.satykrishna at multicorewareinc.com>
Sent: Wednesday, September 8, 2021 10:18 AM
To: Pop, Sebastian
Cc: Liwei Wang; Siva Viswanathan; Janani T E; Development for x265
Subject: RE: [EXTERNAL] [x265] [arm64] Status and combined patch

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

On Tue, Sep 7, 2021 at 8:06 PM Pop, Sebastian <spop at amazon.com<mailto:spop at amazon.com>> wrote:

+x265-devel@ mailing list

Hi Gopi,

Thanks for your feedback. I will check the errors you reported.

I will fix all the issues and re-submit the p2s patch for review.

Could you please send me the exact cmake flags and the commands you used to run the smoke tests?
I want to make sure my testing covers the use cases you have seen failing.
You can use the smoke-tests.txt file from the test folder in the repo  https://github.com/videolan/x265/blob/master/source/test/smoke-tests.txt

I see the following cmake flags in https://github.com/videolan/x265/blob/master/build/linux/multilib.sh#L6

# cmake ../../../source -DHIGH_BIT_DEPTH=ON -DMAIN12=ON

For 8bit you can set  WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=OFF
For 10bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=ON

With this configuration the current code in x265/source/common/aarch64 fails to build.

Would it be ok to remove the code in x265/source/common/aarch64 and submit the p2s routines working with 8bit, 10bit, and 12bit configurations?

On my side I cleaned up aarch64/ipfilter8.S and have it complete with all the functions that x86_64 implements.

I will make sure ipfilter functions pass TestBench with and without HIGH_BIT_DEPTH before I submit the patch for review.

Thanks,

Sebastian

________________________________
From: Gopi Satykrishna Akisetty <gopi.satykrishna at multicorewareinc.com<mailto:gopi.satykrishna at multicorewareinc.com>>
Sent: Monday, September 6, 2021 12:00 AM
To: Pop, Sebastian
Cc: Liwei Wang; Siva Viswanathan; Janani T E
Subject: RE: [EXTERNAL] [x265] [arm64] Status and combined patch

Hi Pop Sebastian,
Sorry for the late reply. We have been running some tests at our end and found that the patch is failing when HIGH_BIT_DEPTH is enabled i.e testbench is failing and also there are output changes with decoder errors in the smoke tests for HIGH_BIT_DEPTH enabled builds. Can you check them at your end once.

Thanks,
Gopi.

On Thu, Aug 19, 2021 at 2:44 AM <spop at amazon.com<mailto:spop at amazon.com>> wrote:
Hello Gopi,

Please see attached the first patch of the series.
It ports p2s function.
Please let me know if the format of the patch is fine.
I will submit the next patches following your guidelines.

Thanks,
Sebastian

On 8/18/21 6:46 AM, Gopi Satykrishna Akisetty wrote:
> Hello Pop Sebastian,
> Thanks for the contribution of ARM64 patches. Can you resend all the
> final patches that have been reviewed by Min Chen over the development
> mailing list, so that it is easier to check and commit each of them
> individually instead of one big combined patch. Please include
> performance numbers and the specs of the test machine used in the
> patch as part of the commit message. Also send all these patches in a
> sequence so that it is easier to apply them and check.
>
> Thanks,
> Gopi.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20210916/f6722335/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm64-port-all-8bit-ipfilters.patch.gz
Type: application/gzip
Size: 23973 bytes
Desc: 0001-arm64-port-all-8bit-ipfilters.patch.gz
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20210916/f6722335/attachment-0001.gz>