[x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror

[Hari Limaye]

Hi JB,

Could you elaborate on why you think this is a bad idea?

Many thanks,
Hari

From: x265-devel <x265-devel-bounces at videolan.org> on behalf of Jean-Baptiste Kempf <jb at videolan.org>
Date: Tuesday, 20 August 2024 at 18:52
To: x265-devel at videolan.org <x265-devel at videolan.org>
Subject: Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror
This is a bad idea. Don’t do that, except in your debut builds.

On Tue, 20 Aug 2024, at 19:42, Hari Limaye wrote:
> Add -Werror when compiling AArch64 intrinsics files to ensure that the
> code is free from compiler warnings.
> ---
>  source/common/CMakeLists.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/source/common/CMakeLists.txt b/source/common/CMakeLists.txt
> index 47b23bcd2..6b4b25618 100644
> --- a/source/common/CMakeLists.txt
> +++ b/source/common/CMakeLists.txt
> @@ -136,6 +136,7 @@ if(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))
>      endif()
>
>      source_group(Assembly FILES ${ASM_PRIMITIVES})
> +    set_source_files_properties(${ASM_PRIMITIVES} PROPERTIES
> COMPILE_FLAGS -Werror)
>  endif(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))
>
>  if(POWER)
> --
> 2.42.1
>
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
> Attachments:
> * 0003-AArch64-Compile-intrinsics-files-with-Werror.patch

--
Jean-Baptiste Kempf -  President
+33 672 704 734
https://jbkempf.com/
_______________________________________________
x265-devel mailing list
x265-devel at videolan.org
https://mailman.videolan.org/listinfo/x265-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20240820/d9815573/attachment-0001.htm>