[libbluray-devel] [PATCH 1/2] Get the correct java home on macOS

[Marvin Scholz]

On 8 Dec 2016, at 3:47, Marvin Scholz wrote:

> [...]
> It turned out the previous patchset actually still did work fine in
> all cases, so this one does not use popen/pclose at all anymore,
> which hopefully works in all cases.
>
> [...]

Of course what I meant to write was:

"It turned out the previous patchset actually still did not work fine in
all cases."

I did some more tests now and the new code was working fine all the time.

If you actually test this in VLC, it will probably still say that Java is
missing, this is a misleading Error messages and is due to libbluray not
finding the libbluray.jar, as it is right now not included in the app bundle.
If you only get

 "This Blu-ray disc needs Java for menus. Disc is played without menus."

it means that probably libbluray.jar is not found.
But if the messages includes

 "Java was not found from your system."

it means that a JVM was not found or could not be loaded.