[x265] Max TU Size
Nicolas Morey-Chaisemartin
nmorey at kalray.eu
Mon Oct 27 15:08:30 CET 2014
Simply changing back the computation SEGV on master (worked on 1.3).
From the look of things, the number of layers in the Search class changed from
m_numLayers = g_log2Size[param.maxCUSize] - 2 + 1;
to
m_numLayers = g_log2Size[param.maxCUSize] - 2;
Some time ago...
Reverting it to the previous value fixes the issue too.
On 10/23/2014 06:25 PM, Steve Borho wrote:
> On 10/23, Nicolas Morey-Chaisemartin wrote:
>> Ok, I'll cleanup and post my patch for that.
>> Also, both max and min TU size are computed in encoder.cpp and params.cpp (once for check, once for the real usage).
>> Would it make sense to store this value somewhere so we can be sure that the value is always the same on both side?
> Those checks in x265_check_params() are fairly unhelpful since they are
> checking variables the user isn't directly providing. That function
> should only be validating things in x265_param, so the checks and error
> messages needs to be in terms of param values.
>
> The checks involving maxLog2CUSize and tuQTMinLog2Size should probably
> be turned into X265_CHECK() calls in initSPS(); while
> x265_check_params() should just make sure param->maxCUSize and
> param->tuQTMaxInterDepth, etc can coexist
>
More information about the x265-devel
mailing list