[libdvdnav-devel] indentation style

Steve Dibb beandog at gentoo.org
Mon Oct 20 20:20:56 CEST 2014


On 10/16/2014 11:08 AM, Diego Biurrun wrote:
> On Thu, Oct 02, 2014 at 12:22:21PM -0600, beandog at gentoo.org wrote:
>>
>> An attempt to cleanup the function to use K&R style.
>
> What the patch you submit transforms it to is closer to, but not quite
> K&R style.
>
>> Feel free to rail on me, and correct indentation, spacing so I can fix
>> it.
>
> While I would certainly prefer libdvd* to be in K&R style, fact is, it's
> mostly done in (idiosyncratic and ugly) VideoLAN style.  So the main
> question here is "Why?" and "Why only this file and function?"...
>
> I would support an effort to reformat the whole (set of) lib(s), but
> just touching one file incompletely makes no sense IMO.

It was intended as a post just to see if I'm going in the right direction before going through and editing the whole file. :)

Steve



More information about the libdvdnav-devel mailing list